Add support for asymetric padding in MKLDNN pool, conv and conv_transpose #21062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test=develop
grygielski
force-pushed
the
grygielski/asymetric_padding
branch
from
644cff1
to
b7cc59a
Compare
test=develop
grygielski
changed the title
|
@zhangting2020 Please take a review! |
Merged
|
Please cherry-pick to release/1.6 @grygielski |
seiriosPlus
pushed a commit
to seiriosPlus/Paddle
that referenced
this pull request
Dec 9, 2019
…pose (PaddlePaddle#21062) * Add asymetric padding support for mkldnn pooling test=develop * Add asymetric padding support for mkldnn conv test=develop * Add asymetric padding support for mkldnn conv_transpose test=develop
seiriosPlus
pushed a commit
to seiriosPlus/Paddle
that referenced
this pull request
Dec 9, 2019
…pose (PaddlePaddle#21062) * Add asymetric padding support for mkldnn pooling test=develop * Add asymetric padding support for mkldnn conv test=develop * Add asymetric padding support for mkldnn conv_transpose test=develop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for asymetric padding (along with "VALID" and "SAME" padding algorithms) in MKL-DNN operators.
Current state:
Pooling
Convolution
Convolution Transpose
MKL-DNN operators with asymetric padding support: pool2d, conv2d, conv3d, conv_transpose
Possible improvements: Add more UTs
@jczaja @luotao1 @bingyanghuang please review