Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GELU grad error #21204

Merged
merged 1 commit into from
Nov 19, 2019
Merged

Conversation

grygielski
Copy link
Contributor

@grygielski grygielski commented Nov 15, 2019

This PR fixes MKL implementation of GELU grad operator.
fix #21120

test=develop
@jczaja
Copy link
Contributor

jczaja commented Nov 15, 2019

@LeoZhao-Intel Could you please take a look at this PR?

Copy link
Contributor

@jczaja jczaja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LeoZhao-Intel
Copy link
Contributor

LGTM

@luotao1 luotao1 merged commit d623e86 into PaddlePaddle:develop Nov 19, 2019
@luotao1
Copy link
Contributor

luotao1 commented Nov 21, 2019

Please cherry-pick to release/1.6 @grygielski

seiriosPlus pushed a commit to seiriosPlus/Paddle that referenced this pull request Dec 9, 2019
seiriosPlus pushed a commit to seiriosPlus/Paddle that referenced this pull request Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TestGelu fails on Grad Diff
4 participants