Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix -Wno-error=sign-compare warning in gcc8 #21434

Merged
merged 3 commits into from
Dec 2, 2019
Merged

fix -Wno-error=sign-compare warning in gcc8 #21434

merged 3 commits into from
Dec 2, 2019

Conversation

luotao1
Copy link
Contributor

@luotao1 luotao1 commented Nov 28, 2019

gongweibao
gongweibao previously approved these changes Nov 29, 2019
Copy link
Contributor

@gongweibao gongweibao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

真不容易。赞呀!

Copy link
Contributor

@gongweibao gongweibao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1 luotao1 merged commit 01fa4ea into PaddlePaddle:develop Dec 2, 2019
@luotao1 luotao1 deleted the gcc8_warning branch December 2, 2019 12:59
seiriosPlus pushed a commit to seiriosPlus/Paddle that referenced this pull request Dec 9, 2019
* fix -Wno-error=sign-compare warning in gcc8

test=develop

* fix warning in distributed codes

test=develop
seiriosPlus pushed a commit to seiriosPlus/Paddle that referenced this pull request Dec 9, 2019
* fix -Wno-error=sign-compare warning in gcc8

test=develop

* fix warning in distributed codes

test=develop
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants