Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix unit tests that do not need to inherit OpTest #21460

Merged
merged 4 commits into from
Dec 4, 2019

Conversation

zhangting2020
Copy link
Contributor

@zhangting2020 zhangting2020 commented Nov 29, 2019

There are unit tests that don't need to inherit OpTest class.
This PR fixes the problem to avoid CI failure in check_grad checking.

related with: PR21455

luotao1
luotao1 previously approved these changes Nov 29, 2019
@zhangting2020 zhangting2020 force-pushed the unittest_fix_pr2 branch 3 times, most recently from 1e1a571 to 3705a9f Compare December 2, 2019 14:56
@zhangting2020 zhangting2020 changed the title fix PythonAPI test in Op unittest fix unit tests that do not need to inherit OpTest Dec 2, 2019
Copy link
Contributor

@luotao1 luotao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhangting2020 zhangting2020 merged commit b1da352 into PaddlePaddle:develop Dec 4, 2019
@zhangting2020 zhangting2020 deleted the unittest_fix_pr2 branch December 4, 2019 07:09
seiriosPlus pushed a commit to seiriosPlus/Paddle that referenced this pull request Dec 9, 2019
* fix PythonAPI test in Op unittest, test=develop
* fix unit tests that do not need to inherit OpTest, test=develop
seiriosPlus pushed a commit to seiriosPlus/Paddle that referenced this pull request Dec 9, 2019
* fix PythonAPI test in Op unittest, test=develop
* fix unit tests that do not need to inherit OpTest, test=develop
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants