Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove not necessary functionalities in Parameter #2271

Merged
merged 3 commits into from
May 26, 2017
Merged

Remove not necessary functionalities in Parameter #2271

merged 3 commits into from
May 26, 2017

Conversation

reyoung
Copy link
Collaborator

@reyoung reyoung commented May 25, 2017 •
edited
Loading

Partially complete issue #2272

  • Extract paddle::getTlsTempBufs to parameter::getThreadLocalBuffer.
  • Clean unused functions
  • Remove Parameter::getPrefetchMatrix function. getPrefetchMatrix is quite simple, should not be extracted as a member function.

@reyoung reyoung mentioned this pull request May 25, 2017
Closed
5 tasks
@reyoung reyoung merged commit da83d28 into PaddlePaddle:develop May 26, 2017
@emailweixu emailweixu mentioned this pull request May 26, 2017
Merged
@reyoung reyoung deleted the feature/clean_parameter_functionalities branch June 27, 2017 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wangkuiyi wangkuiyi wangkuiyi approved these changes

@hedaoyuan hedaoyuan Awaiting requested review from hedaoyuan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@reyoung @wangkuiyi @emailweixu