Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cpu_info without XBYAK #22716

Merged
merged 1 commit into from
Feb 26, 2020

Conversation

grygielski
Copy link
Contributor

Add functionality inside MayIUse() function allowing to check for AVX flags when Paddle is built without XBYAK.

@wojtuss
Copy link

wojtuss commented Feb 24, 2020

This PR fixes #22636

@grygielski
Copy link
Contributor Author

@luotao1 Could you advice on failing CI_GPU_Py2_GCC8 or just rerun if this is random fail?

@luotao1 luotao1 closed this Feb 25, 2020
@luotao1 luotao1 reopened this Feb 25, 2020
@luotao1
Copy link
Contributor

luotao1 commented Feb 25, 2020

I rerun CI_GPU_Py2_GCC8 since it fails on the network.

Copy link

@wojtuss wojtuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@jczaja jczaja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is great, but There is no detection of VNNI . Don't we need that ?

@grygielski
Copy link
Contributor Author

grygielski commented Feb 26, 2020

@jczaja There is no need for checking for VNNI currently in Paddle, hence I didn't add it. But it's great idea of improvement.

@jczaja
Copy link
Contributor

jczaja commented Feb 26, 2020

@grygielski Ok, thanks for answer. LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants