Add ImageExpandFunction. #2449
Merged
Add ImageExpandFunction. #2449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and Col2ImFunctor interfaces.
qingqing01
reviewed
Jun 30, 2017
| namespace paddle { | ||
|
|
||
| /* The storage format of the coldata in the Im2ColFunctor and Col2ImFunctor. */ | ||
| enum ColFormat { kCFO = 0, kOCF = 1 }; |
There was a problem hiding this comment.
这两种格式在Layer里都用嘛？ 我印象中只用了一种吧。 有两种的话，会导致weight是转置关系吗？
C: input channel
F: filter
O: output channel
There was a problem hiding this comment.
kCFO是用在GemmConvFunction卷积计算中的；kOCF是用在这个PR的BlockExpandFunction中的，原先BlockExpandLayer中是用的kCFO这种方式，不过计算完了，还需要再做一次转置才行。
|
Almost LGTM. |
qingqing01
approved these changes
Jul 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2424. Need pr #2282 .