fix cholesky doc, test=develop #25250
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
|
❌This PR is not created using PR's template. You can refer to this Demo. |
jzhang533
requested changes
Jul 9, 2020
python/paddle/tensor/linalg.py
Outdated
| @@ -478,9 +478,11 @@ def dot(x, y, name=None): | |||
|
|
|||
| with fluid.dygraph.guard(): | |||
There was a problem hiding this comment.
使用paddle.enable_imperative开启动态图。
英文文档里也先把 or LoDTensor 给删除吧，动态图现在都不支持LoDTensor。
在FluidDoc里加一下dot的中文文档。
python/paddle/tensor/linalg.py
Outdated
| @@ -682,14 +684,17 @@ def cholesky(x, upper=False): | |||
|
|
|||
| with fluid.dygraph.guard(): | |||
| a = np.random.rand(3, 3) | |||
There was a problem hiding this comment.
使用paddle.enable_imperative开启动态图
| @@ -1165,20 +1165,17 @@ def inverse(input, out=None, name=None): | |||
| (2-D Tensor) or batches of square matrices. | |||
|
|
|||
| Args: | |||
| input (Variable): The input Variable which holds a Tensor. The last two | |||
| x (Variable): The input Variable which holds a Tensor. The last two | |||
| dimensions should be equal. When the number of dimensions is | |||
There was a problem hiding this comment.
The input Variable which holds a Tensor. --> The input tensor.
现在概念上是不是Variable holds tensor，还不明确。。。
| Variable: A Tensor holds the inverse of input. The shape and data type | ||
| is the same as input. | ||
| Variable: A Tensor holds the inverse of x. The shape and data type | ||
| is the same as x. | ||
|
|
||
| Examples: | ||
| .. code-block:: python |
There was a problem hiding this comment.
示例代码只保留动态图版本即可。
用paddle.enable_imperative开启。
jzhang533
reviewed
Jul 16, 2020
python/paddle/tensor/linalg.py
Outdated
| @@ -476,11 +476,13 @@ def dot(x, y, name=None): | |||
| import paddle.fluid as fluid | |||
python/paddle/tensor/linalg.py
Outdated
| @@ -648,7 +650,7 @@ def cross(input, other, dim=None): | |||
| return out | |||
|
|
|||
|
|
|||
| def cholesky(x, upper=False): | |||
| def cholesky(x, upper=False, name=None): | |||
| """ | |||
| :alias_main: paddle.cholesky | |||
| :alias: paddle.cholesky,paddle.tensor.cholesky,paddle.tensor.linalg.cholesky | |||
python/paddle/tensor/linalg.py
Outdated
| @@ -680,17 +682,16 @@ def cholesky(x, upper=False): | |||
| import paddle.fluid as fluid | |||
python/paddle/tensor/math.py
Outdated
| @@ -1155,7 +1155,7 @@ def logsumexp(x, dim=None, keepdim=False, out=None, name=None): | |||
| return layers.log(sum_out, name) | |||
|
|
|||
|
|
|||
| def inverse(input, out=None, name=None): | |||
| def inverse(x, name=None): | |||
| """ | |||
| :alias_main: paddle.inverse | |||
| :alias: paddle.inverse,paddle.tensor.inverse,paddle.tensor.math.inverse | |||
python/paddle/tensor/math.py
Outdated
| @@ -1188,45 +1185,29 @@ def inverse(input, out=None, name=None): | |||
| import paddle.fluid as fluid | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Docs
Describe
fix the doc of cholesky