Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update cross op parameters for API 2.0, test=develop #25354

Merged
merged 2 commits into from
Jul 20, 2020
Merged

update cross op parameters for API 2.0, test=develop #25354

merged 2 commits into from
Jul 20, 2020

Conversation

LutaoChu
Copy link
Contributor

@LutaoChu LutaoChu commented Jul 2, 2020 •
edited
Loading

PR types

Function optimization

PR changes

OPs

Describe

1 update cross op parameters for API 2.0
2 optimize doc string

@paddle-bot-old
Copy link

paddle-bot-old bot commented Jul 2, 2020

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@CLAassistant
Copy link

CLAassistant commented Jul 10, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@LutaoChu LutaoChu force-pushed the cross-op branch 2 times, most recently from 2ecfc84 to b6991d8 Compare July 10, 2020 12:22
wawltor
wawltor approved these changes Jul 15, 2020
View reviewed changes
Copy link
Contributor

@wawltor wawltor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

123malin
123malin approved these changes Jul 16, 2020
View reviewed changes
Copy link
Contributor

@123malin 123malin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

TCChenlong
TCChenlong approved these changes Jul 16, 2020
View reviewed changes
Copy link
Contributor

@TCChenlong TCChenlong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

XiaoguangHu01
XiaoguangHu01 approved these changes Jul 16, 2020
View reviewed changes
Copy link
Contributor

@XiaoguangHu01 XiaoguangHu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wawltor wawltor merged commit bbe8f7b into PaddlePaddle:develop Jul 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@123malin 123malin 123malin approved these changes

@TCChenlong TCChenlong TCChenlong approved these changes

@wawltor wawltor wawltor approved these changes

@XiaoguangHu01 XiaoguangHu01 XiaoguangHu01 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@LutaoChu @CLAassistant @123malin @TCChenlong @wawltor @XiaoguangHu01