randn API: remove out, device, stop_gradient; add name #25409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
wangchaochaohu
previously approved these changes
Jul 7, 2020
lanxianghit
reviewed
Jul 8, 2020
|
|
||
| """ | ||
| if dtype is None: | ||
| dtype = 'float32' |
There was a problem hiding this comment.
调用的gaussian_random，会在gaussian_random里面进行check，这里重复check的话效率比较低
There was a problem hiding this comment.
两个OP名字不一样，这样报错的时候会报gaussian_random出错，而用户会觉得自己没有调用这个op，引起困惑。
效率的问题，静态图是在编译期，所以没有影响，动态图不进行类型检查，也不会有影响。
There was a problem hiding this comment.
check_type(shape, 'shape', (list, tuple, Variable), 'gaussian_random/randn')
check_dtype(dtype, 'dtype', ['float32', 'float64'], 'gaussian_random/randn')
gaussian_random里面的check信息暂时这样写？如果是randn的报错应该也能理解。
zhupengyang
dismissed stale reviews from gfwm2013, swtkiwi, and wangchaochaohu
via
3b768f5
lanxianghit
approved these changes
Jul 14, 2020
gfwm2013
approved these changes
Jul 14, 2020
zhupengyang
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
APIs
Describe