Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

randint API: remove out, device, stop_gradient; add name #25433

Merged
merged 5 commits into from
Jul 15, 2020
Merged

randint API: remove out, device, stop_gradient; add name #25433

merged 5 commits into from
Jul 15, 2020

Conversation

zhupengyang
Copy link
Contributor

PR types

Others

PR changes

APIs

Describe

  • randint
    • remove out, device, stop_gradient
    • add name
    • update doc to 2.0
    • enhance unittest

@paddle-bot-old
Copy link

paddle-bot-old bot commented Jul 8, 2020

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

wangchaochaohu
wangchaochaohu previously approved these changes Jul 8, 2020
View reviewed changes
Copy link
Contributor

@wangchaochaohu wangchaochaohu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lanxianghit
lanxianghit approved these changes Jul 14, 2020
View reviewed changes
Copy link
Contributor

@lanxianghit lanxianghit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

swtkiwi
swtkiwi approved these changes Jul 15, 2020
View reviewed changes
Copy link
Contributor

@swtkiwi swtkiwi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhupengyang zhupengyang merged commit 2250120 into PaddlePaddle:develop Jul 15, 2020
@zhupengyang zhupengyang deleted the randint-0708 branch July 15, 2020 02:31
@zhupengyang zhupengyang changed the title randint API: remove out, devive, stop_gradient; add name randint API: remove out, device, stop_gradient; add name Jul 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swtkiwi swtkiwi swtkiwi approved these changes

@lanxianghit lanxianghit lanxianghit approved these changes

@wangchaochaohu wangchaochaohu Awaiting requested review from wangchaochaohu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@zhupengyang @wangchaochaohu @swtkiwi @lanxianghit