Fix the compare ops for api 2.0, test=develop #25448
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
| @@ -1580,7 +1580,7 @@ def create_array(dtype): | |||
|
|
|||
|
|
|||
| @templatedoc() | |||
| def less_than(x, y, force_cpu=None, cond=None): | |||
| def less_than(x, y, force_cpu=None, name=None, cond=None): | |||
There was a problem hiding this comment.
- name=None可以放到cond=None的后面，保证兼容性
- name参数会在哪里被使用？
There was a problem hiding this comment.
name是前期讨论过的共性问题，静态图中需要增加name这个参数
| auto& place = *context.template device_context<platform::CPUDeviceContext>() | ||
| .eigen_device(); | ||
| auto reduce_dim = Eigen::array<int, 1>({{0}}); | ||
| out.device(place) = ipt.all(reduce_dim); |
There was a problem hiding this comment.
修改了原OP的行为，是否会影响兼容性？
这个是paddle 2.0 alpha的新增的op，因此影响面还好
| "axis", | ||
| "The start dimension index for broadcasting Y onto X. [default -1]") | ||
| .SetDefault(-1) | ||
| .EqualGreaterThan(-1); |
|
Since you haven't replied for more than a year, we have closed this issue/pr. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
APIs
Describe
Fix the compare ops for api 2.0，add dygraph sample