Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ones_like API: remove device, input -> x #25663

Merged
merged 4 commits into from
Jul 28, 2020
Merged

ones_like API: remove device, input -> x #25663

merged 4 commits into from
Jul 28, 2020

Conversation

zhupengyang
Copy link
Contributor

@zhupengyang zhupengyang commented Jul 22, 2020 •
edited
Loading

PR types

Others

PR changes

APIs

Describe

  • ones_like API
    • remove device attr
    • input -> x
    • update doc
      image

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

wangchaochaohu
wangchaochaohu reviewed Jul 22, 2020
View reviewed changes
python/paddle/tensor/creation.py Outdated Show resolved Hide resolved
python/paddle/tensor/creation.py Outdated Show resolved Hide resolved
lanxianghit
lanxianghit reviewed Jul 25, 2020
View reviewed changes
python/paddle/tensor/creation.py Outdated Show resolved Hide resolved
python/paddle/tensor/creation.py Show resolved Hide resolved
lanxianghit
lanxianghit approved these changes Jul 27, 2020
View reviewed changes
Copy link
Contributor

@lanxianghit lanxianghit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhupengyang zhupengyang requested a review from swtkiwi July 27, 2020 07:00
swtkiwi
swtkiwi approved these changes Jul 27, 2020
View reviewed changes
Copy link
Contributor

@swtkiwi swtkiwi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhupengyang zhupengyang merged commit d2f7ac6 into PaddlePaddle:develop Jul 28, 2020
@zhupengyang zhupengyang deleted the ones-like branch July 28, 2020 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wangchaochaohu wangchaochaohu wangchaochaohu left review comments

@swtkiwi swtkiwi swtkiwi approved these changes

@lanxianghit lanxianghit lanxianghit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@zhupengyang @wangchaochaohu @swtkiwi @lanxianghit