Update paddle.clamp
#25906
Merged
Update paddle.clamp
#25906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
willthefrog
force-pushed
the
paddle.clip
branch
8 times, most recently
from
7f1cfd2
to
665e771
Compare
willthefrog
force-pushed
the
paddle.clip
branch
2 times, most recently
from
a1ea928
to
c4a66ff
Compare
willthefrog
requested review from
kolinwei,
zhwesky2010,
jzhang533,
XiaoguangHu01 and
jerrywgz
and removed request for
zhwesky2010
jerrywgz
reviewed
Aug 11, 2020
python/paddle/tensor/math.py
Outdated
| a resulting tensor as the following equation: | ||
|
|
||
| .. math:: | ||
|
|
||
| Out = MIN(MAX(x, min), max) | ||
|
|
||
| Args: | ||
| input (Variable): An input N-D Tensor or LoDTensor | ||
| with data type float32, float64. | ||
| x (Tensor): An N-D Tensor with data type float32 or float64. | ||
| min (float32|Variable): The lower bound with type ``float32`` or a ``Tensor`` |
There was a problem hiding this comment.
Variable -> Tensor here as well?
There was a problem hiding this comment.
good catch, done, thanks!
willthefrog
force-pushed
the
paddle.clip
branch
from
46f86a9
to
955123d
Compare
jzhang533
reviewed
Aug 12, 2020
| :alias_main: paddle.clamp | ||
| :alias: paddle.clamp,paddle.tensor.clamp,paddle.tensor.math.clamp | ||
| :alias_main: paddle.clip | ||
| :alias: paddle.clip,paddle.tensor.clip,paddle.tensor.math.clip |
There was a problem hiding this comment.
这两行写在docstring里的alias标签是可以去掉的。
kolinwei
previously approved these changes
Aug 14, 2020
willthefrog
force-pushed
the
paddle.clip
branch
2 times, most recently
from
77269e0
to
1aa2436
Compare
willthefrog
force-pushed
the
paddle.clip
branch
from
fa389fa
to
28daf5f
Compare
kolinwei
previously approved these changes
Aug 20, 2020
rename to `paddle.clip` add fast path for dygraph mode remove `out` rename `input` -> `x` update doc sample
also trigger CI
willthefrog
force-pushed
the
paddle.clip
branch
3 times, most recently
from
fb1eb36
to
1d4272e
Compare
willthefrog
force-pushed
the
paddle.clip
branch
from
1d4272e
to
4cd06c5
Compare
willthefrog
force-pushed
the
paddle.clip
branch
2 times, most recently
from
2579542
to
2a59b0e
Compare
kolinwei
approved these changes
Aug 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Breaking changes
PR changes
APIs
Describe
rename to
paddle.clipadd fast path for dygraph mode
remove
outrename
input->xupdate doc sample
also fix
cosine_similarityconflict