Fix macos compile #2591
Merged
Fix macos compile #2591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Please use `override` not `virtual` in sub-classes. `override` can check if there is a method in `parent` while compiling.
Closed
|
Thanks @reyoung tell me that In subclass we should write only virtual or only override, if we use both, clang will throw error like "error: 'xxx' overrides a member function but is not marked 'override'" LGTM! |
jacquesqiao
approved these changes
Jun 24, 2017
wangkuiyi
reviewed
Jun 26, 2017
| @@ -309,35 +309,35 @@ class CombinedEvaluator : public Evaluator { | |||
| void addEvaluator(std::unique_ptr<Evaluator>&& evaluator) { | |||
| evaluators_.emplace_back(std::move(evaluator)); | |||
| } | |||
| virtual void start() { | |||
| void start() override { | |||
There was a problem hiding this comment.
I don't get it -- why is keyword override a key to Mac OS X build? @reyoung @jacquesqiao
There was a problem hiding this comment.
OK. I got it from @jacquesqiao 's comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please use
overridenotvirtualin sub-classes.overridecan check if there is a method inparentwhile compiling.Fix #2588