Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding platform/must_check.h #2600

Conversation

reyoung
Copy link
Collaborator

@reyoung reyoung commented Jun 26, 2017

__must_check is a macro mark of function return value. It let developer
must check the return value is legal or not.

__must_check is a macro mark of function return value. It let developer
must check the return value is legal or not.
Copy link
Contributor

@gangliao gangliao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@reyoung reyoung merged commit 109fc93 into PaddlePaddle:develop Jun 26, 2017
@reyoung reyoung deleted the feature/moving_compiler_flags_to_platform branch June 27, 2017 12:42
@wangkuiyi
Copy link
Collaborator

I listed my doubts about this PR in #2629 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants