Feature/add proto attrs #2604
Feature/add proto attrs #2604
Conversation
Make paddle framework use Error as Error Type.
|
CI error is because of protobuf's issue protocolbuffers/protobuf#2425 |
reyoung
force-pushed
the
feature/add_proto_attrs
branch
from
ee42af8
to
a4e4d19
Compare
reyoung
force-pushed
the
feature/add_proto_attrs
branch
from
a4e4d19
to
e815fe2
Compare
Also fix protobuf 3.1.0 error * Depends on protobuf 3.1.0, not an alpha version * Remove Wextra, because protobuf 3.1.0 don't pass GCC check
reyoung
force-pushed
the
feature/add_proto_attrs
branch
from
7d3271a
to
deeef35
Compare
| @@ -101,15 +101,16 @@ set(COMMON_FLAGS | |||
| -fPIC | |||
| -fno-omit-frame-pointer | |||
| -Wall | |||
| -Wextra | |||
| # go_extern will download extern go project. | ||
| # go_extern(target_name extern_source) | ||
| # go_extern(go_redis github.com/hoisie/redis) | ||
| function(go_extern TARGET_NAME) |
There was a problem hiding this comment.
Why we need this function in generic.cmake?
| endfunction(go_extern) | ||
|
|
||
|
|
||
| function(generate_protobuf_cpp SRCS HDRS) |
There was a problem hiding this comment.
According to the documented convention at the beginning of this header file, what we need is proto_library. But the adding of proto_libary seems should be in a separate PR that fixes #2567.
| @@ -14,19 +14,18 @@ limitations under the License. */ | |||
|
|
|||
| #pragma once | |||
|
|
|||
| #include <glog/logging.h> | |||
There was a problem hiding this comment.
Let's try don't use the string typed error until we know we must use it. I had this idea because at least in @jacquesqiao 's PR #2629 (comment), we don't need this error type.
| @@ -0,0 +1,8 @@ | |||
| syntax="proto3"; | |||
There was a problem hiding this comment.
I understand unit test source files are named something like xxx_test.cc, but what is xxx_test.proto for?
| @@ -0,0 +1,192 @@ | |||
| #pragma once | |||
There was a problem hiding this comment.
I don't quite understand what goal all the code here is trying to achieve. It might be easier if there is a design doc like paddle/framework/variable.md for paddle/framework/variable.h.
|
Closed, AttributeReader move to PR #2604 |
No description provided.