[Api2.0] add pixel shuffle class #26071

shippingwang · 2020-08-09T19:33:21Z

PR types

New features

PR changes

APIs

Describe

This PR

add pixel shuffle functional function and PixelShuffle class
support data_format in pixel_shuffle api

paddle-bot-old · 2020-08-09T19:33:25Z

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

… add_pixel_shuffle_cls

python/paddle/nn/functional/vision.py

python/paddle/nn/functional/__init__.py

python/paddle/nn/functional/vision.py

python/paddle/nn/layer/vision.py

willthefrog · 2020-08-18T03:00:18Z

python/paddle/nn/functional/vision.py

+
+
+def pixel_shuffle(x, upscale_factor, data_format="NCHW", name=None):
+    """


no need for duplicated docstrings for functional version, just refer to class doc

Yep, It is the same thing.

literally, just remove the duplicated description (bug keep the args and stuff) and add a reference to the Layer version.

python/paddle/nn/layer/vision.py

paddle/fluid/operators/pixel_shuffle_op.cc

python/paddle/nn/functional/vision.py

… add_pixel_shuffle_cls

shippingwang · 2020-08-19T14:21:25Z

@willthefrog Codes have been refined after first time reviewing, feel free to re-review while passing tests

willthefrog

please reply to each comment before making new review request, otherwise it is hard for the reviewer to keep track of the changes

shippingwang · 2020-08-20T03:14:36Z

please reply to each comment before making new review request, otherwise it is hard for the reviewer to keep track of the changes

Done

willthefrog · 2020-08-20T03:22:17Z

python/paddle/nn/functional/vision.py

+
+
+def pixel_shuffle(x, upscale_factor, data_format="NCHW", name=None):
+    """


literally, just remove the duplicated description (bug keep the args and stuff) and add a reference to the Layer version.

willthefrog

LGTM

willthefrog

LGTM

add pixel shuffle class

8533194

shippingwang added 6 commits August 12, 2020 06:55

Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…

dbf21c2

… add_pixel_shuffle_cls

merge dev

ab05575

Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…

30e0344

… add_pixel_shuffle_cls

Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…

821507f

… add_pixel_shuffle_cls

add data format

ca751a0

fix bug

2269ab9

shippingwang requested review from XiaoguangHu01 and willthefrog August 17, 2020 14:18

willthefrog requested changes Aug 18, 2020

View reviewed changes

refine

d9533b2

willthefrog requested changes Aug 18, 2020

View reviewed changes

python/paddle/nn/functional/vision.py Outdated Show resolved Hide resolved

python/paddle/nn/functional/vision.py Outdated Show resolved Hide resolved

shippingwang closed this Aug 18, 2020

shippingwang reopened this Aug 18, 2020

shippingwang added 4 commits August 18, 2020 05:25

Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…

b3cea08

… add_pixel_shuffle_cls

fix

23cb839

fix bug

eb2fdc0

fix

5d23a77

shippingwang requested a review from willthefrog August 19, 2020 14:10

willthefrog requested changes Aug 20, 2020

View reviewed changes

fix typo

59450d0

shippingwang force-pushed the add_pixel_shuffle_cls branch from 5fcd94d to 59450d0 Compare August 20, 2020 02:40

willthefrog requested changes Aug 20, 2020

View reviewed changes

shippingwang added 2 commits August 20, 2020 05:48

vision.py

6ceae74

refine doc

985112d

shippingwang requested a review from willthefrog August 20, 2020 08:54

willthefrog previously approved these changes Aug 20, 2020

View reviewed changes

fix unittestgit status!

e7d68bb

shippingwang dismissed willthefrog’s stale review via e7d68bb August 21, 2020 12:19

shippingwang added 3 commits August 23, 2020 04:15

fix graph

b54e8df

fix coverage

9e63bb0

fix conflict

f55e2e1

shippingwang requested a review from willthefrog August 24, 2020 13:51

willthefrog approved these changes Aug 24, 2020

View reviewed changes

shippingwang merged commit 1f82c0c into PaddlePaddle:develop Aug 24, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Api2.0] add pixel shuffle class #26071

[Api2.0] add pixel shuffle class #26071

shippingwang commented Aug 9, 2020 •

edited

Loading

paddle-bot-old bot commented Aug 9, 2020

willthefrog Aug 18, 2020

shippingwang Aug 20, 2020

willthefrog Aug 20, 2020

shippingwang commented Aug 19, 2020 •

edited

Loading

willthefrog left a comment

shippingwang commented Aug 20, 2020

willthefrog Aug 20, 2020

willthefrog left a comment

willthefrog left a comment



		def pixel_shuffle(x, upscale_factor, data_format="NCHW", name=None):
		"""

[Api2.0] add pixel shuffle class #26071

[Api2.0] add pixel shuffle class #26071

Conversation

shippingwang commented Aug 9, 2020 • edited Loading

PR types

PR changes

Describe

paddle-bot-old bot commented Aug 9, 2020

willthefrog Aug 18, 2020

Choose a reason for hiding this comment

shippingwang Aug 20, 2020

Choose a reason for hiding this comment

willthefrog Aug 20, 2020

Choose a reason for hiding this comment

shippingwang commented Aug 19, 2020 • edited Loading

willthefrog left a comment

Choose a reason for hiding this comment

shippingwang commented Aug 20, 2020

willthefrog Aug 20, 2020

Choose a reason for hiding this comment

willthefrog left a comment

Choose a reason for hiding this comment

willthefrog left a comment

Choose a reason for hiding this comment

shippingwang commented Aug 9, 2020 •

edited

Loading

shippingwang commented Aug 19, 2020 •

edited

Loading