Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add paddle.nn.functional.mse_loss #26089

Merged
merged 4 commits into from
Aug 15, 2020
Merged

add paddle.nn.functional.mse_loss #26089

merged 4 commits into from
Aug 15, 2020

Conversation

baiyfbupt
Copy link
Contributor

@baiyfbupt baiyfbupt commented Aug 10, 2020 •
edited
Loading

PR types

Others

PR changes

APIs

Describe

  1. Add nn.functional.mse_loss and corresponding unittest

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@baiyfbupt baiyfbupt requested a review from zhiqiu August 11, 2020 11:39
@baiyfbupt baiyfbupt closed this Aug 12, 2020
@baiyfbupt baiyfbupt reopened this Aug 12, 2020
zhiqiu
zhiqiu reviewed Aug 12, 2020
View reviewed changes
Copy link
Contributor

@zhiqiu zhiqiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
A small issue, what about the performance of the combination of small layers(ops)?

@baiyfbupt baiyfbupt closed this Aug 14, 2020
@baiyfbupt baiyfbupt reopened this Aug 14, 2020
@baiyfbupt
Copy link
Contributor Author

image

@baiyfbupt baiyfbupt merged commit 22b06db into PaddlePaddle:develop Aug 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhiqiu zhiqiu zhiqiu left review comments

@wanghaoshuang wanghaoshuang wanghaoshuang approved these changes

@yaoxuefeng6 yaoxuefeng6 yaoxuefeng6 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@baiyfbupt @zhiqiu @wanghaoshuang @yaoxuefeng6