Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix the margin ranking loss doc and api, test=develop #26266

Merged
merged 2 commits into from
Aug 17, 2020
Merged

fix the margin ranking loss doc and api, test=develop #26266

merged 2 commits into from
Aug 17, 2020

Conversation

wawltor
Copy link
Contributor

@wawltor wawltor commented Aug 14, 2020

PR types

Others

PR changes

APIs

Describe

update the target to the label, change the out to output

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@wawltor wawltor closed this Aug 14, 2020
@wawltor wawltor reopened this Aug 14, 2020
@wawltor wawltor closed this Aug 15, 2020
@wawltor wawltor reopened this Aug 15, 2020
@PaddlePaddle PaddlePaddle locked and limited conversation to collaborators Aug 15, 2020
@PaddlePaddle PaddlePaddle unlocked this conversation Aug 15, 2020
zhiqiu
zhiqiu approved these changes Aug 17, 2020
View reviewed changes
Copy link
Contributor

@zhiqiu zhiqiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhiqiu zhiqiu merged commit d03dd9d into PaddlePaddle:develop Aug 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhiqiu zhiqiu zhiqiu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wawltor @zhiqiu