Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix pserver test #2630

Merged
merged 1 commit into from
Jun 28, 2017
Merged

fix pserver test #2630

merged 1 commit into from
Jun 28, 2017

Conversation

helinwang
Copy link
Contributor

No description provided.

@Yancey1989
Copy link
Contributor

I checked out this PR, but it also failed with go test ./..., maybe I missed something?

$ go test ./...
?   	github.com/PaddlePaddle/Paddle/go/cmd/master	[no test files]
?   	github.com/PaddlePaddle/Paddle/go/cmd/pserver	[no test files]
?   	github.com/PaddlePaddle/Paddle/go/connection	[no test files]
ok  	github.com/PaddlePaddle/Paddle/go/master	0.991s
?   	github.com/PaddlePaddle/Paddle/go/master/c	[no test files]
signal: killed
FAIL	github.com/PaddlePaddle/Paddle/go/pserver	0.008s
?   	github.com/PaddlePaddle/Paddle/go/pserver/cclient	[no test files]
ok  	github.com/PaddlePaddle/Paddle/go/utils/networkhelper	0.019s

Copy link
Contributor

@dzhwinter dzhwinter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dzhwinter
Copy link
Contributor

dzhwinter commented Jun 28, 2017

confirmed.

@typhoonzero
Copy link
Contributor

typhoonzero commented Jun 28, 2017

@Yancey1989 you need to upgrade go to > 1.8.1, this was a go bug.


Thanks @typhoonzero , go test ./... can pass all the test. --Yancey1989

Copy link
Contributor

@typhoonzero typhoonzero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Yancey1989 Yancey1989 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@helinwang helinwang merged commit 2f52cb7 into PaddlePaddle:develop Jun 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants