Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[API 2.0] Add api paddle.reshape(x, shape, name) #26338

Merged
merged 5 commits into from
Aug 20, 2020
Merged

[API 2.0] Add api paddle.reshape(x, shape, name) #26338

merged 5 commits into from
Aug 20, 2020

Conversation

liym27
Copy link
Contributor

@liym27 liym27 commented Aug 16, 2020 •
edited
Loading

PR types

Others

PR changes

APIs

Describe

Optimize api paddle.reshape for API2.0
image

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot-old
Copy link

paddle-bot-old bot commented Aug 16, 2020 •
edited
Loading

✅ This PR's description meets the template requirements!
Please wait for other CI results.

@wangchaochaohu
Copy link
Contributor

wangchaochaohu commented Aug 17, 2020 •
edited
Loading

paddle.tensor.split(x, num_or_sections, axis=0, name=None)

修改tensor下的split函数对齐最新的设计 同时单测完善了类型检查完善

@liym27 liym27 changed the title [API 2.0] Optimize api reshape:(1)Add type check for attr act;(2)Delete attr inplace [API 2.0] Add api paddle.reshape(x, shape, name) Aug 17, 2020
@PaddlePaddle PaddlePaddle deleted a comment from wangchaochaohu Aug 17, 2020
@PaddlePaddle PaddlePaddle deleted a comment from wangchaochaohu Aug 17, 2020
@PaddlePaddle PaddlePaddle deleted a comment from wangchaochaohu Aug 17, 2020
mapingshuo
mapingshuo previously approved these changes Aug 18, 2020
View reviewed changes
Copy link
Contributor

@mapingshuo mapingshuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the reshepe API

wangchaochaohu
wangchaochaohu previously approved these changes Aug 18, 2020
View reviewed changes
Copy link
Contributor

@wangchaochaohu wangchaochaohu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liym27
[API 2.0] (1)Add api paddle.reshape(x, shape, name); (2)Use Tensor re…
ef11f87 
…places Variable. test=develop

Change-Id: I92916cce860d5f779c98c643b8745227b636b6ef
@liym27
to_variable -> to_tensor. test=develop
7d857fe 
Change-Id: I9113c9a394883341d2db635d0f3f1f7316bff654
@liym27
Fix code according to reviews. test=develop
e52cb39 
Change-Id: Id01217e3e7a3eabacda5aa701756ba42ef820797
@liym27
fix code. test=develop
3799723 
Change-Id: Ia9ce2b225e04171e9bf248f4965d28e760f785bf
@liym27 liym27 dismissed stale reviews from wangchaochaohu and mapingshuo via ca20575 August 18, 2020 12:13
zhhsplendid
zhhsplendid previously approved these changes Aug 18, 2020
View reviewed changes
Copy link
Member

@zhhsplendid zhhsplendid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liym27
remove import reshape. test=develop
f3dfc2c 
Change-Id: Ic5074bd843ebdf754ff86117f7795a77c7fef8d5
zhhsplendid
zhhsplendid approved these changes Aug 20, 2020
View reviewed changes
Copy link
Member

@zhhsplendid zhhsplendid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liym27 liym27 merged commit adba432 into PaddlePaddle:develop Aug 20, 2020
@liym27 liym27 mentioned this pull request Aug 20, 2020
Merged
@liym27 liym27 deleted the api20_reshape branch December 9, 2020 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhhsplendid zhhsplendid zhhsplendid approved these changes

@wangchaochaohu wangchaochaohu wangchaochaohu approved these changes

@mapingshuo mapingshuo mapingshuo left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@liym27 @wangchaochaohu @zhhsplendid @mapingshuo