Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

【API 2.0】Add conv1d API #26350

Merged
merged 17 commits into from
Aug 23, 2020
Merged

【API 2.0】Add conv1d API #26350

merged 17 commits into from
Aug 23, 2020

Conversation

wanghaoshuang
Copy link
Contributor

@wanghaoshuang wanghaoshuang commented Aug 17, 2020 •
edited

PR types

Others

PR changes

APIs

Describe

Add conv1d API to modules:

  1. paddle.nn.functional
  2. paddle.fluid.layers
  3. paddle.nn

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot-old
Copy link

paddle-bot-old bot commented Aug 17, 2020 •
edited

✅ This PR's description meets the template requirements!
Please wait for other CI results.

baiyfbupt
baiyfbupt reviewed Aug 18, 2020
View reviewed changes
python/paddle/nn/functional/conv.py Outdated Show resolved Hide resolved
python/paddle/fluid/layers/nn.py Outdated Show resolved Hide resolved
python/paddle/fluid/layers/nn.py Outdated Show resolved Hide resolved
python/paddle/nn/functional/conv.py Outdated Show resolved Hide resolved
python/paddle/nn/layer/conv.py Outdated Show resolved Hide resolved
python/paddle/nn/layer/conv.py Outdated Show resolved Hide resolved
ceci3
ceci3 reviewed Aug 18, 2020
View reviewed changes
python/paddle/fluid/layers/nn.py Outdated Show resolved Hide resolved
python/paddle/fluid/layers/nn.py Outdated Show resolved Hide resolved
python/paddle/nn/functional/conv.py Outdated Show resolved Hide resolved
python/paddle/nn/functional/conv.py Outdated Show resolved Hide resolved
python/paddle/nn/layer/conv.py Outdated Show resolved Hide resolved
python/paddle/nn/layer/conv.py Outdated Show resolved Hide resolved
willthefrog
willthefrog requested changes Aug 20, 2020
View reviewed changes
python/paddle/nn/functional/conv.py Outdated Show resolved Hide resolved
python/paddle/nn/functional/conv.py Outdated Show resolved Hide resolved
python/paddle/nn/functional/conv.py Outdated Show resolved Hide resolved
WuHaobo
WuHaobo reviewed Aug 22, 2020
View reviewed changes
Copy link
Contributor

@WuHaobo WuHaobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

willthefrog
willthefrog requested changes Aug 22, 2020
View reviewed changes
python/paddle/nn/__init__.py Show resolved Hide resolved
python/paddle/nn/layer/__init__.py Show resolved Hide resolved
python/paddle/nn/functional/conv.py Outdated Show resolved Hide resolved
@wanghaoshuang wanghaoshuang mentioned this pull request Aug 22, 2020
Closed
WuHaobo
WuHaobo approved these changes Aug 23, 2020
View reviewed changes
Copy link
Contributor

@WuHaobo WuHaobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

WuHaobo
WuHaobo previously approved these changes Aug 23, 2020
View reviewed changes
heavengate
heavengate previously approved these changes Aug 23, 2020
View reviewed changes
@wanghaoshuang wanghaoshuang dismissed stale reviews from heavengate and WuHaobo via 5703c5d August 23, 2020 06:34
@wanghaoshuang
Fix unitest
506f768 
test=develop
willthefrog
willthefrog approved these changes Aug 23, 2020
View reviewed changes
Copy link
Contributor

@willthefrog willthefrog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wanghaoshuang wanghaoshuang merged commit e2b82e0 into PaddlePaddle:develop Aug 23, 2020
@wanghaoshuang wanghaoshuang deleted the conv1d branch May 20, 2022 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baiyfbupt baiyfbupt baiyfbupt left review comments

@ceci3 ceci3 ceci3 left review comments

@LielinJiang LielinJiang LielinJiang left review comments

@willthefrog willthefrog willthefrog approved these changes

@heavengate heavengate heavengate left review comments

@WuHaobo WuHaobo WuHaobo left review comments

@qingqing01 qingqing01 Awaiting requested review from qingqing01

@XiaoguangHu01 XiaoguangHu01 Awaiting requested review from XiaoguangHu01

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@wanghaoshuang @willthefrog @heavengate @WuHaobo @baiyfbupt @ceci3 @LielinJiang