fix dim problem #2636
Merged
fix dim problem #2636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacquesqiao
commented
Jun 28, 2017
| @@ -109,7 +109,10 @@ def pre_scan(self, dat): | |||
| if len(self.__shape__) > 3: | |||
| raise ValueError( | |||
| "The dimension of input cannot be greater than 3.") | |||
| self.__dim__ = reduce(lambda x, y: x * y, self.__shape__) | |||
| if len(self.__shape__) == 0: | |||
| self.__dim__ = 1 | |||
There was a problem hiding this comment.
After discuss with @qingqing01 , we think if user configure to use a dence_vector, then the data type should be a vector and shape should not be zero
qingqing01
reviewed
Jun 28, 2017
| @@ -109,7 +109,10 @@ def pre_scan(self, dat): | |||
| if len(self.__shape__) > 3: | |||
| raise ValueError( | |||
| "The dimension of input cannot be greater than 3.") | |||
| self.__dim__ = reduce(lambda x, y: x * y, self.__shape__) | |||
| if len(self.__shape__) == 0: | |||
| self.__dim__ = 1 | |||
There was a problem hiding this comment.
The DenseScanner must accept the data type dense_vector. So the dat in line 108 must be a list ([]) or numpy.array. See the input type doc.
The format of input data in issue is not correct.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #2564
check the input shape of dense_vector.