Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename the inputs of allclose #26360

Merged
merged 3 commits into from
Aug 20, 2020

Conversation

zhangting2020
Copy link
Contributor

@zhangting2020 zhangting2020 commented Aug 17, 2020

PR types

Function optimization

PR changes

APIs

Describe

rename the inputs of allclose

image
image
image

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@zhangting2020 zhangting2020 force-pushed the allclose branch 6 times, most recently from 5d90e90 to 5ba6165 Compare August 17, 2020 16:17
class TestAllcloseError(unittest.TestCase):
def test_input_dtype(self):
def test_x_dtype():
with fluid.program_guard(fluid.Program()):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

新添加的单测中可以弱化fluid 该带 可以使用paddle.static.program_guard

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Copy link
Contributor

@luotao1 luotao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@wangchaochaohu wangchaochaohu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@XiaoguangHu01 XiaoguangHu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -91,83 +93,81 @@ def equal_all(x, y, name=None):


@templatedoc()
def allclose(input, other, rtol=1e-05, atol=1e-08, equal_nan=False, name=None):
def allclose(x, y, rtol=1e-05, atol=1e-08, equal_nan=False, name=None):
"""
:alias_main: paddle.allclose
:alias: paddle.allclose,paddle.tensor.allclose,paddle.tensor.logic.allclose

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可以将“alias_main”、“alias”这两行删去,后期会自动化增加

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

另提PR修改文档问题。

@zhangting2020 zhangting2020 merged commit 6914a12 into PaddlePaddle:develop Aug 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants