-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rename the inputs of allclose #26360
Conversation
Thanks for your contribution! |
5d90e90
to
5ba6165
Compare
class TestAllcloseError(unittest.TestCase): | ||
def test_input_dtype(self): | ||
def test_x_dtype(): | ||
with fluid.program_guard(fluid.Program()): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
新添加的单测中可以弱化fluid 该带 可以使用paddle.static.program_guard
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
5ba6165
to
4916400
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -91,83 +93,81 @@ def equal_all(x, y, name=None): | |||
|
|||
|
|||
@templatedoc() | |||
def allclose(input, other, rtol=1e-05, atol=1e-08, equal_nan=False, name=None): | |||
def allclose(x, y, rtol=1e-05, atol=1e-08, equal_nan=False, name=None): | |||
""" | |||
:alias_main: paddle.allclose | |||
:alias: paddle.allclose,paddle.tensor.allclose,paddle.tensor.logic.allclose | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
可以将“alias_main”、“alias”这两行删去,后期会自动化增加
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
另提PR修改文档问题。
PR types
Function optimizationPR changes
APIsDescribe
rename the inputs of allclose