【2.0 API】Enhance affine grid operator #26385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Add cuda kernel 2. Add align corners options test=develop
|
Thanks for your contribution! |
|
问题一、能否将对3D的支持推迟一下？
问题二、还需要为paddle.nn.functional.affine_grid写单测么？
|
wanghaoshuang
requested review from
qingqing01,
heavengate,
XiaoguangHu01 and
LielinJiang
willthefrog
requested changes
Aug 18, 2020
|
test=develop
wanghaoshuang
force-pushed
the
grid_api
branch
from
453688a
to
d91f592
Compare
willthefrog
requested changes
Aug 19, 2020
| namespace ops = paddle::operators; | ||
| REGISTER_OP_CUDA_KERNEL( | ||
| affine_grid, | ||
| ops::AffineGridOpKernel<paddle::platform::CUDADeviceContext, float>, |
There was a problem hiding this comment.
so the cuda version mostly reused the eigen implementation? some preliminary benchmark would be nice if time permits.
There was a problem hiding this comment.
Added CUDA kernel.
I will give some performance benchmark on CUDNN version and CUDA kernel version in the future.
Currently, it will use CUDNN kernel when align_corners is true and use CUDA kernel when align_corners is false.
test=develop
willthefrog
previously approved these changes
Aug 24, 2020
wanghaoshuang
dismissed stale reviews from saxon-zh and willthefrog
via
de31410
test=develop
wanghaoshuang
force-pushed
the
grid_api
branch
from
4a1141b
to
dd46209
Compare
… grid_api test=develop
wanghaoshuang
force-pushed
the
grid_api
branch
from
60b1c28
to
1057b18
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
OPs
Describe