Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable users to set intial memory states for lstm/gru group #2641

Merged
merged 2 commits into from
Jun 29, 2017

Conversation

lcy-seso
Copy link
Contributor

enable users to set the initial states of lstmemory_group and gru_group.

@lcy-seso lcy-seso requested review from luotao1 and livc June 28, 2017 03:50
@lcy-seso lcy-seso force-pushed the enable_boot_memory_for_lstm branch 3 times, most recently from 7d75076 to b76d6fc Compare June 28, 2017 05:12
@@ -765,7 +770,8 @@ def lstmemory_group(input,

:param input: input layer name.
:type input: LayerOutput
:param name: lstmemory group name.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line should be retained?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

@lcy-seso lcy-seso force-pushed the enable_boot_memory_for_lstm branch 5 times, most recently from 74e5343 to 512eba6 Compare June 28, 2017 07:53
@livc
Copy link
Member

livc commented Jun 29, 2017

this pr can fix #1613

@lcy-seso lcy-seso force-pushed the enable_boot_memory_for_lstm branch 4 times, most recently from b373981 to 2b9b712 Compare June 29, 2017 08:28
@lcy-seso lcy-seso force-pushed the enable_boot_memory_for_lstm branch from 2b9b712 to b0ad9c9 Compare June 29, 2017 08:30
@lcy-seso lcy-seso requested a review from qingqing01 June 29, 2017 08:54
@lcy-seso lcy-seso merged commit d011514 into PaddlePaddle:develop Jun 29, 2017
@lcy-seso lcy-seso deleted the enable_boot_memory_for_lstm branch June 29, 2017 09:31
@livc livc mentioned this pull request Jun 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants