Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add paddle.gather for API2.0 #26455

Merged
merged 19 commits into from
Aug 23, 2020
Merged

add paddle.gather for API2.0 #26455

merged 19 commits into from
Aug 23, 2020

Conversation

wangchaochaohu
Copy link
Contributor

@wangchaochaohu wangchaochaohu commented Aug 19, 2020 •
edited
Loading

PR types

New features

PR changes

OPs

Describe

gather(x, index, axis=None, name=None)

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@wangchaochaohu wangchaochaohu changed the title 【WIP】Gather op add paddle.gather for API2.0 Aug 21, 2020
ForFishes
ForFishes approved these changes Aug 22, 2020
View reviewed changes
Copy link
Member

@ForFishes ForFishes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

XiaoguangHu01
XiaoguangHu01 approved these changes Aug 23, 2020
View reviewed changes
Copy link
Contributor

@XiaoguangHu01 XiaoguangHu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

python/paddle/fluid/layers/nn.py Show resolved Hide resolved
TCChenlong
TCChenlong approved these changes Aug 23, 2020
View reviewed changes
Copy link
Contributor

@TCChenlong TCChenlong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

zhiqiu
zhiqiu approved these changes Aug 23, 2020
View reviewed changes
Copy link
Contributor

@zhiqiu zhiqiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for op_function_generator.cc

@wangchaochaohu wangchaochaohu merged commit ebf9b21 into PaddlePaddle:develop Aug 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhiqiu zhiqiu zhiqiu approved these changes

@TCChenlong TCChenlong TCChenlong approved these changes

@heavengate heavengate heavengate approved these changes

@ForFishes ForFishes ForFishes approved these changes

@XiaoguangHu01 XiaoguangHu01 XiaoguangHu01 approved these changes

@zhupengyang zhupengyang Awaiting requested review from zhupengyang

@lanxianghit lanxianghit Awaiting requested review from lanxianghit

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@wangchaochaohu @zhiqiu @TCChenlong @heavengate @ForFishes @XiaoguangHu01