basic impl of operator #2667
Closed
basic impl of operator #2667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add background.
* Simplify background description. * Not using Error as return value, use PADDLE_ENFORCE
…ute_design_for_op
…ute_design_for_op
… operator-impl
Add copy right and comments Update design doc
reyoung
reviewed
Jun 29, 2017
paddle/framework/operator.h
Outdated
| class AttrbuteMap { | ||
| public: | ||
| template <typename T> | ||
| Error get(const std::string key, T* attr) const; |
There was a problem hiding this comment.
Maybe we should not use Error.
paddle/framework/operator.h
Outdated
|
|
||
| input_vars.reserve(inputs_.size()); | ||
| for (auto& input : inputs_) { | ||
| input_vars.push_back(scope->getOrCreateVariable(input)); |
There was a problem hiding this comment.
Maybe scope usage should be updated
Since we do not merge all PR about op together, so we use operator.md
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
merged design to this pr.
Please review Design doc for operator attribute first