Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove sorted_sum_gradient_ form BasicEngine and PartialGradTask. #26766

Merged
merged 1 commit into from
Aug 28, 2020
Merged

Remove sorted_sum_gradient_ form BasicEngine and PartialGradTask. #26766

merged 1 commit into from
Aug 28, 2020

Conversation

wzzju
Copy link
Contributor

@wzzju wzzju commented Aug 28, 2020 •
edited

PR types

Others

PR changes

Others

Describe

  • Remove sorted_sum_gradient_ form BasicEngine and PartialGradTask.
  • Use Tensor instead of Variable in the doc of paddle.grad.
    documentation_docs_en_api_dygraph_grad

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@wzzju
Remove sorted_sum_gradient_ form BasicEngine and PartialGradTask.
1ab78a8 
Use `Tensor` instead of `Variable`  in the doc of paddle.grad.
TCChenlong
TCChenlong approved these changes Aug 28, 2020
View reviewed changes
Copy link
Contributor

@TCChenlong TCChenlong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

zhhsplendid
zhhsplendid approved these changes Aug 28, 2020
View reviewed changes
Copy link
Member

@zhhsplendid zhhsplendid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wzzju wzzju merged commit f32ae27 into PaddlePaddle:develop Aug 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhhsplendid zhhsplendid zhhsplendid approved these changes

@TCChenlong TCChenlong TCChenlong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wzzju @zhhsplendid @TCChenlong