Refine bernoulli and unsqueeze op #26842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
chenwhql
reviewed
Sep 1, 2020
| // NOTE(zhiqiu): currently, PADDLE_ENFORCE in cuda kernel may print several | ||
| // lines of error messages if, and it should be refined. | ||
| PADDLE_ENFORCE(p >= 0.0 && p <= 1.0, | ||
| "The probability should >=0 and <= 1, but got %f", p); |
There was a problem hiding this comment.
这里是should >= 0，下面是should be <= 1，要不要统一下？
zhiqiu
added a commit
to zhiqiu/Paddle
that referenced
this pull request
Sep 1, 2020
* add check for bernoulli and register bool for unsqueeze * follow comments
zhiqiu
added a commit
that referenced
this pull request
Sep 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
OPs
Describe
add check for bernoulli cuda kernel
register bool for unsqueeze kernel
refine doc of paddle.stack