fix typo for interp_v2,test=develop #26843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
willthefrog
reviewed
Sep 4, 2020
| @@ -114,6 +115,8 @@ def interpolate(x, | |||
| smoother than corresponding surfaces obtained by bilinear interpolation or | |||
| nearest-neighbor interpolation. | |||
|
|
|||
| Area interpolation is same as adaptive avg pooling. | |||
There was a problem hiding this comment.
Area 插值 找不到比较官方的概念介绍
There was a problem hiding this comment.
this should be either removed or revised, as interpolation is definitely not the same as pooling.
There was a problem hiding this comment.
Ok，has been removed.
There was a problem hiding this comment.
please also delete line 91
and implementation codes in line 287, and line 316 ~ line 322
please run a grep on the file
There was a problem hiding this comment.
polish the notes, please review~
willthefrog
previously approved these changes
Sep 4, 2020
|
in_d, in_h, in_w -> depth, height, width |
jzhang533
reviewed
Sep 7, 2020
| And :attr:`out_shape` has a higher priority than :attr:`scale_factor`.Has to match input size if it is a list. | ||
| scale_factor (float|Tensor|list|tuple|None): The multiplier for the input height or width. At | ||
| least one of :attr:`size` or :attr:`scale_factor` must be set. | ||
| And :attr:`size` has a higher priority than :attr:`scale_factor`.Has to match input size if it is a list. |
There was a problem hiding this comment.
:attr:scale_factor.Has to match input size if it is a list.
是tensor的时候也要match吧。
python/paddle/nn/layer/common.py
Outdated
| And :attr:`out_shape` has a higher priority than :attr:`scale_factor`.Has to match input size if it is a list. | ||
| scale_factor (float|Tensor|list|tuple|None): The multiplier for the input height or width. At | ||
| least one of :attr:`size` or :attr:`scale_factor` must be set. | ||
| And :attr:`size` has a higher priority than :attr:`scale_factor`.Has to match input size if it is a list. |
python/paddle/nn/layer/common.py
Outdated
| And :attr:`out_shape` has a higher priority than :attr:`scale_factor`. | ||
| scale_factor (float|int|list|tuple|Tensor|None): The multiplier for the input height or width. At | ||
| least one of :attr:`size` or :attr:`scale_factor` must be set. | ||
| And :attr:`size` has a higher priority than :attr:`scale_factor`. | ||
| Default: None. Has to match input size if it is a list. |
tink2123
added a commit
to tink2123/Paddle
that referenced
this pull request
Sep 8, 2020
* fix typo for interp_v2,test=develop * align with torch, test=develop * add area mode, test=develop * fix bug, test=develop * format notes, test=develop * update for converage, test=develop * fix bilinear, test=develop * fix bicubic, test=develop * fix typo, test=develop * fix coverage, test=develop * fix helper.input_dtype, test=develop * polish notes, test=develop * polish notes, test=develop * polish notes, test=develop
ceci3
pushed a commit
that referenced
this pull request
Sep 8, 2020
* fix typo for interp_v2,test=develop * align with torch, test=develop * add area mode, test=develop * fix bug, test=develop * format notes, test=develop * update for converage, test=develop * fix bilinear, test=develop * fix bicubic, test=develop * fix typo, test=develop * fix coverage, test=develop * fix helper.input_dtype, test=develop * polish notes, test=develop * polish notes, test=develop * polish notes, test=develop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Bug fixes
PR changes
APIs
Describe