fix weight #26986
Merged
fix weight #26986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
jzhang533
reviewed
Sep 8, 2020
python/paddle/nn/functional/input.py
Outdated
| @@ -209,6 +210,10 @@ def embedding(x, weight, padding_idx=None, sparse=False, name=None): | |||
| padding_idx = -1 if padding_idx is None else padding_idx if padding_idx >= 0 else ( | |||
| weight.shape[0] + padding_idx) | |||
|
|
|||
| if padding_idx >= weight.shape[0] or padding_idx <= -weight.shape[0]: | |||
There was a problem hiding this comment.
开闭区间的处理不对吧？
文档里这么写的：
padding_idx needs to be in the interval [-weight.shape[0], weight.shape[0])
python/paddle/nn/layer/common.py
Outdated
| if self._embedding_dim <= 0: | ||
| raise ValueError("embedding_dim must be gather than 0") | ||
|
|
||
| if self._padding_idx >= num_embeddings or self._padding_idx <= -num_embeddings: |
chalsliu
approved these changes
Sep 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Bug fixes
PR changes
APIs
Describe
fix nn.Embedding‘s attr
weightfix doc