Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ERNIE GPU inference with shared params in multihead matmul #27121

Merged
merged 1 commit into from
Sep 8, 2020

Conversation

cryoco
Copy link
Contributor

@cryoco cryoco commented Sep 7, 2020

PR types

Bug fixes

PR changes

Others

Describe

If weights or biases in qkv's fc are shared by multiple multihead_matmul patterns, we do not support this kind of fusion, multihead_matmul_fuse_pass_v2 will not take effect.

@paddle-bot-old
Copy link

paddle-bot-old bot commented Sep 7, 2020

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@cryoco cryoco changed the title fix multihead matmul shared params Fix ERNIE GPU inference with shared params in multihead matmul Sep 7, 2020
@cryoco cryoco requested a review from NHZlX September 7, 2020 08:58
Copy link
Contributor

@jiweibo jiweibo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cryoco cryoco merged commit 5fb8c92 into PaddlePaddle:develop Sep 8, 2020
@cryoco cryoco deleted the fix-multihead-shared-params branch September 8, 2020 02:42
cryoco added a commit to cryoco/Paddle that referenced this pull request Sep 8, 2020
cryoco added a commit to cryoco/Paddle that referenced this pull request Sep 15, 2020
cryoco added a commit that referenced this pull request Sep 16, 2020
* fix multihead matmul shared params (#27121)

* fix multihead matmul shared params
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants