[Dy2stat] Change the Global Switch Name of ProgramTranslator for API 2.0 #27203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
zhhsplendid
force-pushed
the
change_global_switch_name
branch
from
c843f53
to
0681abf
Compare
liym27
previously approved these changes
Sep 10, 2020
chenwhql
reviewed
Sep 11, 2020
| @@ -300,16 +300,17 @@ def __call__(self, *args, **kwargs): | |||
| """ | |||
|
|
|||
| # 1. call dygraph function directly if not enable `declarative` | |||
| if not self._program_trans.enable_declarative: | |||
| if not self._program_trans.enable_static: | |||
There was a problem hiding this comment.
maybe enable_to_static is better? keep consistent with paddle.jit.to_static
because we have paddle.disable_static, users may be confused whether it is related to enable_static here
zhhsplendid
dismissed stale reviews from lanxianghit and liym27
via
702d8e8
… change_global_switch_name, test=develop
… change_global_switch_name, test=develop
liym27
approved these changes
Sep 15, 2020
Aurelius84
approved these changes
Sep 16, 2020
lanxianghit
approved these changes
Sep 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
APIs
Describe
Change ProgramTranslator.enable_declarative to ProgramTranslator.enable_to_static to meet API 2.0