Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 3 pass version check #27283

Merged
merged 3 commits into from
Sep 18, 2020
Merged

Add 3 pass version check #27283

merged 3 commits into from
Sep 18, 2020

Conversation

haozech
Copy link
Contributor

@haozech haozech commented Sep 14, 2020 •
edited
Loading

PR types

New features

PR changes

OPs

Describe

Add three passes' version check

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@haozech
Copy link
Contributor Author

haozech commented Sep 16, 2020 •
edited
Loading

@shangzhizhou 辛苦review下，三个pass的单测都已存在：
python/paddle/fluid/tests/unittests/ir/inference/test_conv_elementwise_add_fuse_pass.py

python/paddle/fluid/tests/unittests/ir/inference/test_conv_elementwise_add_act_fuse_pass.py

python/paddle/fluid/tests/unittests/ir/inference/test_conv_elementwise_add2_act_fuse_pass.py

shangzhizhou
shangzhizhou reviewed Sep 16, 2020
View reviewed changes
Copy link
Member

@shangzhizhou shangzhizhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

在确认op属性都支持的情况下，请在单测中添加版本检测用例，可参考卫波已合入PR

shangzhizhou
shangzhizhou reviewed Sep 17, 2020
View reviewed changes
python/paddle/fluid/tests/unittests/ir/inference/test_conv_elementwise_add2_act_fuse_pass.py Outdated
@@ -46,6 +47,7 @@ def test_check_output(self):
if core.is_compiled_with_cuda():
use_gpu = True
self.check_output_with_option(use_gpu)
PassVersionChecker.IsCompatible('conv_elementwise_add2_act_fuse_pass')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

需要添加返回值断言
self.assertTrue(...)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, thanks

python/paddle/fluid/tests/unittests/ir/inference/test_conv_elementwise_add_act_fuse_pass.py Outdated
@@ -48,6 +49,7 @@ def test_check_output(self):
if core.is_compiled_with_cuda():
use_gpu = True
self.check_output_with_option(use_gpu)
PassVersionChecker.IsCompatible('conv_elementwise_add_act_fuse_pass')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

同上

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, thanks

python/paddle/fluid/tests/unittests/ir/inference/test_conv_elementwise_add_fuse_pass.py Outdated
@@ -44,6 +45,7 @@ def test_check_output(self):
if core.is_compiled_with_cuda():
use_gpu = True
self.check_output_with_option(use_gpu)
PassVersionChecker.IsCompatible('conv_elementwise_add_fuse_pass')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

同上

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, thanks

shangzhizhou
shangzhizhou approved these changes Sep 17, 2020
View reviewed changes
Copy link
Member

@shangzhizhou shangzhizhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@haozech
Copy link
Contributor Author

haozech commented Sep 17, 2020

@Superjomn 辛苦review下

Superjomn
Superjomn approved these changes Sep 17, 2020
View reviewed changes
Copy link
Contributor

@Superjomn Superjomn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Superjomn
Superjomn approved these changes Sep 17, 2020
View reviewed changes
Copy link
Contributor

@Superjomn Superjomn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Superjomn
Superjomn reviewed Sep 17, 2020
View reviewed changes
Copy link
Contributor

@Superjomn Superjomn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

需要增加精度测试

@DannyIsFunny DannyIsFunny merged commit 7e6dfcf into PaddlePaddle:develop Sep 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Superjomn Superjomn Superjomn approved these changes

@shangzhizhou shangzhizhou shangzhizhou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@haozech @Superjomn @shangzhizhou @DannyIsFunny