Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add adaptivelsgd in meta_optimizer #27289

Merged
merged 5 commits into from
Sep 16, 2020

Conversation

ForFishes
Copy link
Member

@ForFishes ForFishes commented Sep 14, 2020

PR types

New features

PR changes

Others

Describe

add adaptivelsgd in meta_optimizer.

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@@ -24,7 +24,7 @@ def __init__(self, optimizer):
self.meta_optimizers_white_list = [
"LarsOptimizer", "LambOptimizer", "RecomputeOptimizer",
"LocalSGDOptimizer", "GradientMergeOptimizer",
"GraphExecutionOptimizer"
"GraphExecutionOptimizer", "AdaptiveLocalSGDOptimizer"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

新建一行,且用逗号结束,避免未来出现冲突

@@ -25,7 +25,9 @@ def __init__(self, optimizer):
super(LocalSGDOptimizer, self).__init__(optimizer)
self.inner_opt = optimizer
self.meta_optimizers_white_list = []
self.meta_optimizers_black_list = ["GraphExecutionOptimizer"]
self.meta_optimizers_black_list = [
"GraphExecutionOptimizer", "AdaptiveLocalSGDOptimizer"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

新建一行,且用逗号结束

Copy link
Collaborator

@gavin1332 gavin1332 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ForFishes ForFishes merged commit 54b81fa into PaddlePaddle:develop Sep 16, 2020
@ForFishes ForFishes deleted the adaptive_lsgd branch September 16, 2020 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants