Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix dll load bug on windows from python3.8 #27324

Merged
merged 1 commit into from
Sep 17, 2020

Conversation

zhwesky2010
Copy link
Contributor

@zhwesky2010 zhwesky2010 commented Sep 15, 2020

PR types

Bug fixes

PR changes

Others

Describe

fix dll load bug on windows from python3.8.

Toblerity/Fiona#851

https://docs.python.org/3/library/os.html#os.add_dll_directory

image

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot-old
Copy link

paddle-bot-old bot commented Sep 15, 2020

✅ This PR's description meets the template requirements!
Please wait for other CI results.

Copy link
Contributor

@gfwm2013 gfwm2013 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhwesky2010 zhwesky2010 merged commit a7fadce into PaddlePaddle:develop Sep 17, 2020
gfwm2013 pushed a commit to gfwm2013/Paddle that referenced this pull request Sep 21, 2020
gfwm2013 added a commit that referenced this pull request Sep 22, 2020
* Fix test_gast_with_compatibility.py due to the problem of gast in python3.8 (#27433)

test=develop

* fix dll load bug on windows from python3.8 (#27324)

* Support python3.8 (#26850)

* Support python3.8

test=notest

* Replace the 'spawn' start method with 'fork' start method for multiprocessing, on MacOS with python>=3.8 (#27317)

* Replace the 'spawn' start method with 'fork' start method for multiprocessing, on MacOs when python>=3.8

test=develop

* Correct the error in decorator.py (#27409)

test=develop

Co-authored-by: Zhou Wei <52485244+zhouwei25@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants