Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix cmake error #2735

Merged
merged 2 commits into from
Jul 5, 2017
Merged

fix cmake error #2735

merged 2 commits into from
Jul 5, 2017

Conversation

gongweibao
Copy link
Contributor

No description provided.

@dzhwinter
Copy link
Contributor

fix #2720

@reyoung
Copy link
Collaborator

reyoung commented Jul 4, 2017

Maybe we should add WITH_GOLANG in our TeamCity CI-Server. @helinwang

@helinwang
Copy link
Contributor

@reyoung Thanks let letting me know! Please merge this ASAP so people's PR CI can pass after doing a rebase / pull.
Btw, I am on vacation, please let people know they need to rebase to the latest develop branch if their CI fails.

helinwang
helinwang approved these changes Jul 5, 2017
View reviewed changes
Copy link
Contributor

@helinwang helinwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please merge this ASAP so people's PR CI can pass after doing a rebase / pull.

@helinwang helinwang merged commit fa21616 into PaddlePaddle:develop Jul 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@helinwang helinwang helinwang approved these changes

@reyoung reyoung Awaiting requested review from reyoung

@gangliao gangliao Awaiting requested review from gangliao

@jacquesqiao jacquesqiao Awaiting requested review from jacquesqiao

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gongweibao @dzhwinter @reyoung @helinwang