Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

register pass compatibility #27357

Merged
merged 5 commits into from
Sep 18, 2020
Merged

Conversation

cryoco
Copy link
Contributor

@cryoco cryoco commented Sep 16, 2020

PR types

Others

PR changes

Others

Describe

  1. register pass compatibility for conv_bn_fuse_pass, conv_affine_channel_fuse_pass, repeated_fc_relu_fuse_pass, shuffle_channel_detect_pass
  2. fix bugs of repeated_fc_relu_fuse_pass when input dims is not 2

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@cryoco cryoco changed the title pass compatibility register pass compatibility Sep 16, 2020
def test_check_output(self):
self.check_output()

PassVersionChecker.IsCompatible('conv_affine_channel_fuse_pass')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

需要添加断言
self.assertTrue

def test_check_output(self):
self.check_output()

PassVersionChecker.IsCompatible('conv_affine_channel_fuse_pass')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

同上

def test_check_output(self):
self.check_output()

PassVersionChecker.IsCompatible('conv_affine_channel_fuse_pass')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

同上,以下相同情况请统一修复

shangzhizhou
shangzhizhou previously approved these changes Sep 17, 2020
Copy link
Member

@shangzhizhou shangzhizhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Superjomn Superjomn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cryoco cryoco merged commit fd7ab4e into PaddlePaddle:develop Sep 18, 2020
@cryoco cryoco deleted the pass-compatible branch September 18, 2020 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants