make places of DataLoader optional. #27432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
heavengate
changed the title
heavengate
requested review from
saxon-zh,
qingqing01,
LielinJiang,
XiaoguangHu01 and
chenwhql
chenwhql
reviewed
Sep 22, 2020
python/paddle/fluid/reader.py
Outdated
| be 1. Default None. | ||
| places(list(Place)|tuple(Place)|optional): a list of Place, | ||
| to put data onto, :attr:`places` should be None in dynamic | ||
| graph mode. if :attr:`places` is None in static mode, default |
There was a problem hiding this comment.
should be None? maybe can be None is better?
python/paddle/fluid/reader.py
Outdated
| be 1. Default None. | ||
| places(list(Place)|tuple(Place)|optional): a list of Place, | ||
| to put data onto, :attr:`places` should be None in dynamic | ||
| graph mode. if :attr:`places` is None in static mode, default |
There was a problem hiding this comment.
in static mode? not dynamic?
chenwhql
previously approved these changes
Sep 22, 2020
… optional_place_in_dataloader
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Function optimization
PR changes
APIs
Describe
make
placesargument inpaddle.io.DataLoaderoptionalplacenot set(None), use_current_expected_place()instead