fix cmake errors #2745
Merged
fix cmake errors #2745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacquesqiao
reviewed
Jul 5, 2017
| @@ -284,7 +284,7 @@ function(go_library TARGET_NAME) | |||
| add_custom_command(TARGET ${TARGET_NAME} POST_BUILD | |||
| COMMAND rm "${${TARGET_NAME}_LIB_PATH}" | |||
| # Golang build source code | |||
| COMMAND env GOPATH=${GOPATH} ${CMAKE_Go_COMPILER} build ${BUILD_MODE} | |||
| COMMAND env LIBRARY_PATH=${CMAKE_BINARY_DIR}/go/pserver/client/c/:$ENV{LIBRARY_PATH} GOPATH=${GOPATH} ${CMAKE_Go_COMPILER} build ${BUILD_MODE} | |||
There was a problem hiding this comment.
我也觉得太丑陋了。这个 和 @gangliao 商量他后边会做优化。我们先让大家的研发不会被block。
比写死在.go里边好了一点点，这里的cmake路径是可以探测的。
里边还有一个更丑陋的。：)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.