Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move dygraph amp api to paddle-2.0 #27681

Merged
merged 2 commits into from
Sep 30, 2020

Conversation

zhiqiu
Copy link
Contributor

@zhiqiu zhiqiu commented Sep 28, 2020

PR types

New features

PR changes

APIs

Describe

Move dygraph amp api to paddle-2.0

As discussed,

paddle.fluid.dygraph.amp_guard -> paddle.amp.auto_cast
paddle.fluid.dygraph.AmpScaler -> paddle.amp.GradScaler

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

lanxianghit
lanxianghit previously approved these changes Sep 28, 2020
Copy link
Contributor

@jzhang533 jzhang533 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

叫autocast是不是更好?(torch里是torch.cuda.amp.autocast)

jzhang533
jzhang533 previously approved these changes Sep 29, 2020
Copy link
Contributor

@jzhang533 jzhang533 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zhiqiu
Copy link
Contributor Author

zhiqiu commented Sep 29, 2020

叫autocast是不是更好?(torch里是torch.cuda.amp.autocast)

已线下讨论,使用auto_cast,更符合paddle的命名规范。

Copy link
Contributor

@jzhang533 jzhang533 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@XiaoguangHu01 XiaoguangHu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhiqiu zhiqiu merged commit 69a3339 into PaddlePaddle:develop Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants