Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[API 2.0: doc] fix doc of nonzero #27685

Merged
merged 5 commits into from
Sep 30, 2020
Merged

[API 2.0: doc] fix doc of nonzero #27685

merged 5 commits into from
Sep 30, 2020

Conversation

123malin
Copy link
Contributor

@123malin 123malin commented Sep 28, 2020 •
edited
Loading

PR types

Others

PR changes

APIs

Describe

  1. fix doc of paddle.nonzero
  2. remove alias of paddle.fluid.optimizer.lookaheadoptimizer, paddle.fluid.optimizer.modelaverage
    image

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@123malin 123malin changed the title fluid.layer.api move to paddle. Rewrite Examples of paddle.optimizer.LookAheadOptimizer, paddle.optimizer.ModelAverage, paddle.nonzero Sep 28, 2020
jzhang533
jzhang533 reviewed Sep 29, 2020
View reviewed changes
Copy link
Contributor

@jzhang533 jzhang533 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • paddle.optimizer.LookAheadOptimizer, paddle.optimizer.ModelAverage 是静态图专用的，可以暂时先不迁移
  • nonzero的参数名称input 改为 x
  • nonzero文档中的Variable改为Tensor。

@123malin
Copy link
Contributor Author

  • paddle.optimizer.LookAheadOptimizer, paddle.optimizer.ModelAverage 是静态图专用的，可以暂时先不迁移
  • nonzero的参数名称input 改为 x
  • nonzero文档中的Variable改为Tensor
    好的，已修改。

@123malin 123malin changed the title Rewrite Examples of paddle.optimizer.LookAheadOptimizer, paddle.optimizer.ModelAverage, paddle.nonzero [API 2.0: doc] fix doc of nonzero Sep 29, 2020
@PaddlePaddle PaddlePaddle locked and limited conversation to collaborators Sep 30, 2020
@PaddlePaddle PaddlePaddle unlocked this conversation Sep 30, 2020
jzhang533
jzhang533 approved these changes Sep 30, 2020
View reviewed changes
Copy link
Contributor

@jzhang533 jzhang533 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

XiaoguangHu01
XiaoguangHu01 approved these changes Sep 30, 2020
View reviewed changes
Copy link
Contributor

@XiaoguangHu01 XiaoguangHu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@123malin 123malin merged commit 54c368d into PaddlePaddle:develop Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jzhang533 jzhang533 jzhang533 approved these changes

@XiaoguangHu01 XiaoguangHu01 XiaoguangHu01 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@123malin @jzhang533 @XiaoguangHu01