Fix new remote updater for go pserver #2774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dzhwinter
reviewed
Jul 7, 2017
go/pserver/optimizer.go
Outdated
| "ConfigSize": len(c), | ||
| }).Info("New Optimizer Created with config:") | ||
| var cbuffer unsafe.Pointer | ||
| cbuffer = C.malloc(C.size_t(len(p.Content))) | ||
| C.memcpy(cbuffer, unsafe.Pointer(&p.Content[0]), C.size_t(len(p.Content))) | ||
| C.memcpy(cbuffer, unsafe.Pointer(&p.Content[0]), C.size_t(len(p.Content)/C.sizeof_float)) |
There was a problem hiding this comment.
it is so strange that we can pass the go test smoothly.
what's more, C.memcpy copy four times longer buffer than the real length, it never core dump(system call libc's memcpy in low level), and set all the data to 0 as normal.
There was a problem hiding this comment.
Wired, maybe the test case is not exposing this problem?
There was a problem hiding this comment.
Oh, no, we malloc four times memory.......
cbuffer = C.malloc(C.size_t(len(p.Content))), it absolutly will run smoothly because I waste the rest buffer.
weird, by the way. : )
… fix_newupdater
|
LGTM! |
dzhwinter
approved these changes
Jul 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2761