Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add voc2012 dataset for image segment #2785

Merged
merged 11 commits into from
Jul 19, 2017

Conversation

wanghaoshuang
Copy link
Contributor

fix #2784

import tarfile
import io
import numpy as np
from common import download
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

common是否应为 paddle.v2.dataset.common

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx.

"""
Create a train dataset reader containing 2913 images in HWC order.
"""
return reader_creator(download(VOC_URL, 'voc_seg', VOC_MD5), 'trainval')
Copy link
Contributor

@guoshengCS guoshengCS Jul 13, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个数据集好像不只是包含了分割任务的数据,是否更改下缓存目录的名字'voc_seg'会好些,其他任务的数据也可以使用

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea!

Copy link
Contributor

@qingqing01 qingqing01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM. And please to resolve conflicts.

# See the License for the specific language governing permissions and
# limitations under the License.

import paddle.v2.dataset.voc_seg
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PEP8 style https://www.python.org/dev/peps/pep-0008/#package-and-module-names says:

Modules should have short, all-lowercase names. Underscores can be used in the module name if it improves readability.

Here the underscore doesn't really improve the readability, how about naming it voc2012 instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx. I have renamed it to voc2012.

@wanghaoshuang
Copy link
Contributor Author

@qingqing01 I have resolved conflicts.

@qingqing01 qingqing01 merged commit c1ebb31 into PaddlePaddle:develop Jul 19, 2017
@wanghaoshuang wanghaoshuang deleted the voc_dataset branch June 1, 2018 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add voc2012 dataset for image segment
4 participants