Add voc2012 dataset for image segment #2785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guoshengCS
reviewed
Jul 13, 2017
python/paddle/v2/dataset/voc_seg.py
Outdated
| import tarfile | ||
| import io | ||
| import numpy as np | ||
| from common import download |
There was a problem hiding this comment.
common是否应为 paddle.v2.dataset.common
python/paddle/v2/dataset/voc_seg.py
Outdated
| """ | ||
| Create a train dataset reader containing 2913 images in HWC order. | ||
| """ | ||
| return reader_creator(download(VOC_URL, 'voc_seg', VOC_MD5), 'trainval') |
There was a problem hiding this comment.
这个数据集好像不只是包含了分割任务的数据，是否更改下缓存目录的名字'voc_seg'会好些，其他任务的数据也可以使用
qingqing01
reviewed
Jul 17, 2017
wangkuiyi
reviewed
Jul 17, 2017
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| import paddle.v2.dataset.voc_seg |
There was a problem hiding this comment.
The PEP8 style https://www.python.org/dev/peps/pep-0008/#package-and-module-names says:
Modules should have short, all-lowercase names. Underscores can be used in the module name if it improves readability.
Here the underscore doesn't really improve the readability, how about naming it voc2012 instead?
There was a problem hiding this comment.
Thx. I have renamed it to voc2012.
|
@qingqing01 I have resolved conflicts. |
qingqing01
approved these changes
Jul 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #2784