Add method converting Tensor to Eigen TensorMap #2805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QiJune
requested review from
reyoung,
JiayiFeng,
hedaoyuan,
jacquesqiao,
qingqing01 and
gangliao
QiJune
changed the title
reyoung
reviewed
Jul 17, 2017
paddle/operators/add_op.h
Outdated
| void Compute(const KernelContext& context) const override { | ||
| auto input0 = context.Input(0)->Get<framework::Tensor>(); | ||
| auto input1 = context.Input(1)->Get<framework::Tensor>(); | ||
| auto* output = context.Output(0)->GetMutable<framework::Tensor>(); |
There was a problem hiding this comment.
Maybe output->mutable_data could hide in context.GetOutputTensor<>()
reyoung
reviewed
Jul 17, 2017
paddle/operators/add_op.h
Outdated
| auto input1 = context.Input(1)->Get<framework::Tensor>(); | ||
| auto* output = context.Output(0)->GetMutable<framework::Tensor>(); | ||
|
|
||
| output->mutable_data<T>(Place()); |
There was a problem hiding this comment.
Only Place as argument is not enough.
There was a problem hiding this comment.
Output's dim have been set in InferShape method. So just pass a Place is enough.
The following code is a little repeated
output->mutable_data<T>(output->dims(), Place());
reyoung
approved these changes
Jul 18, 2017
| @@ -37,6 +39,13 @@ class Tensor { | |||
| } | |||
|
|
|||
| template <typename T> | |||
| T* raw_data() const { | |||
There was a problem hiding this comment.
Since we always use raw_data in OpKernel. The mutable_data is only used for allocation. Maybe we could change mutable_data to allocation
QiJune
force-pushed
the
tensor_to_EigenTensor
branch
from
467b044
to
4d49f1d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.