Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refine CUDA Related libraries #2806

Merged
merged 2 commits into from
Jul 12, 2017
Merged

Refine CUDA Related libraries #2806

merged 2 commits into from
Jul 12, 2017

Conversation

reyoung
Copy link
Collaborator

@reyoung reyoung commented Jul 11, 2017 •
edited by jacquesqiao
Loading

fix: #2804
Still, WIP, because my notebook does not contain a CUDA device. So testing is slow.

QiJune
QiJune approved these changes Jul 12, 2017
View reviewed changes
Copy link
Member

@QiJune QiJune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
And I will split device_context.h into context.h and cuda_context.h in next PR. So, just merge this PR first.

@QiJune QiJune merged commit 2749b71 into PaddlePaddle:develop Jul 12, 2017
@reyoung reyoung deleted the feature/refine_cuda_h branch July 12, 2017 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QiJune QiJune QiJune approved these changes

@jacquesqiao jacquesqiao Awaiting requested review from jacquesqiao

@gangliao gangliao Awaiting requested review from gangliao

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cuda.h compile problem
2 participants
@reyoung @QiJune