Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix pybind compile question #2819

Merged
merged 1 commit into from
Jul 12, 2017
Merged

fix pybind compile question #2819

merged 1 commit into from
Jul 12, 2017

Conversation

luotao1
Copy link
Contributor

@luotao1 luotao1 commented Jul 12, 2017

fix #2818

reyoung
reyoung approved these changes Jul 12, 2017
View reviewed changes
Copy link
Collaborator

@reyoung reyoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

It seems that it is a compiler problem? It cannot be in MacOS and Ubuntu 14.04. However, adding Python.h is harmless.

@luotao1
Copy link
Contributor Author

luotao1 commented Jul 12, 2017

It cannot be in MacOS and Ubuntu 14.04.

Yes, my machine is CentOS release 6.3 (Final).

@luotao1 luotao1 merged commit 9695eb9 into PaddlePaddle:develop Jul 12, 2017
@luotao1 luotao1 deleted the compile branch July 12, 2017 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reyoung reyoung reyoung approved these changes

@jacquesqiao jacquesqiao Awaiting requested review from jacquesqiao

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

compile question
2 participants
@luotao1 @reyoung