Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go_binary: remove hardcoded library link path, add pserver client test #2832

Merged
merged 2 commits into from
Jul 13, 2017
Merged

go_binary: remove hardcoded library link path, add pserver client test #2832

merged 2 commits into from
Jul 13, 2017

Conversation

helinwang
Copy link
Contributor

@helinwang helinwang commented Jul 12, 2017 •
edited
Loading

The hardcoded link path is no longer needed. (fixed by #2811)

@helinwang helinwang changed the title go_binary: remove hardcoded library link path go_binary: remove hardcoded library link path, add pserver client test Jul 12, 2017
dzhwinter
dzhwinter approved these changes Jul 13, 2017
View reviewed changes
Copy link
Contributor

@dzhwinter dzhwinter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

gangliao
gangliao approved these changes Jul 13, 2017
View reviewed changes
Copy link
Contributor

@gangliao gangliao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gangliao gangliao merged commit e6e2bf4 into PaddlePaddle:develop Jul 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gangliao gangliao gangliao approved these changes

@dzhwinter dzhwinter dzhwinter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@helinwang @gangliao @dzhwinter